Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incremental build for autoFVT tasks #29735

Open
wants to merge 1 commit into
base: integration
Choose a base branch
from

Conversation

fritze2
Copy link
Member

@fritze2 fritze2 commented Sep 26, 2024

  • Current behavior is that the Gradle autoFVT task runs every time that a user runs buildfat for a FAT bucket. The reason it does is because we clean the directory where autoFVT outputs into on every run, whether there was a change or not, and we do not define inputs or outputs for the ad-hoc task.
  • Expected behavior is the build shouldn't clean the autoFVTDir unless there was a change in the inputs, and the autoFVT task needs inputs and outputs defined correctly to determine when to run the clean.
  • Saves time in re-builds locally, and could save time in remote builds if we restore caches of ~/.gradle and FAT's build/ directories.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • Please describe in a separate comment how you tested your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants