This repository has been archived by the owner on May 3, 2023. It is now read-only.
Add error page #25
Merged
Add error page #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablothedude
force-pushed
the
feature/add-error-page
branch
5 times, most recently
from
df236aa
to
74d929c
Compare
pmeulen
force-pushed
the
feature/add-error-page
branch
from
74d929c
to
6568f80
Compare
MKodde
reviewed
Mar 11, 2021
| @@ -0,0 +1,19 @@ | |||
| <?php | |||
|
|
|||
There was a problem hiding this comment.
I believe you should add the copyright notice to this file.
There was a problem hiding this comment.
Is still WIP, this will be fixed in: #27, after the legal team is consulted.
| public function __invoke(Throwable $exception): Response | ||
| { | ||
| return $this->render('default/error.html.twig', [ | ||
| 'message' => $exception->getMessage(), |
There was a problem hiding this comment.
Is this desirable? Showing the exception message without being certain what text may be on there? We may run a risk at disclosing sensitive data here.
There was a problem hiding this comment.
Changed it to use static translations
pablothedude
force-pushed
the
feature/add-error-page
branch
from
6568f80
to
a2919d3
Compare
MKodde
approved these changes
Mar 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/176891048