feat: hash cmd hsetnx #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lqxhub
reviewed
Dec 5, 2023
| } | ||
|
|
||
| auto hash = value->CastHash(); | ||
| if (hash->insert(PHash::value_type(client->argv_[2], client->argv_[3])).second) { |
There was a problem hiding this comment.
这里是不是也要加锁处理, 如果多个客户端同时操作, 可能会出现,查询没有,但是在插入时, 多个客户端同时插入数据
There was a problem hiding this comment.
类似这个pr里的处理 在 store 层加锁,保证 查询和插入时原子操作
|
handle conflict & use blackwidow interface |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues #38