feat: add blackwidow to support kv to redis type #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lqxhub
reviewed
Nov 23, 2023
src/pstd/env.h
Outdated
| @@ -0,0 +1,157 @@ | |||
| #ifndef __PSTD_ENV_H__ | |||
There was a problem hiding this comment.
#ifndef 改成 #pragma once 吧 和前面统一
src/pstd/pstd_slice.h
Outdated
| // non-const method, all threads accessing the same Slice must use | ||
| // external synchronization. | ||
|
|
||
| #ifndef __PSTD_SLICE_H__ |
There was a problem hiding this comment.
pstd_slice.h 和 pstd_status.h 这两个文件之前就移植过来了, 只是名字没加pstd_ 这个前缀, 可以把原来的文件重命名一下
AlexStocks
reviewed
Nov 25, 2023
src/pstd/lock_mgr.cc
Outdated
| @@ -0,0 +1,177 @@ | |||
| // Copyright (c) 2017-present The storage Authors. All rights reserved. | |||
|
QX：注意添加 lz4 snappy 依赖 |
|
1 引入 bw； |
AlexStocks
reviewed
Nov 27, 2023
cmake/rocksdb.cmake
Outdated
| @@ -7,8 +7,9 @@ include_guard() | |||
| FetchContent_Declare( | |||
| rocksdb | |||
| GIT_REPOSITORY https://github.com/facebook/rocksdb.git | |||
| GIT_TAG v8.6.7 | |||
| GIT_TAG v8.3.3 | |||
AlexStocks
reviewed
Nov 27, 2023
| @@ -0,0 +1,681 @@ | |||
| #include "env.h" | |||
AlexStocks
reviewed
Nov 27, 2023
| SequentialFile::~SequentialFile() = default; | ||
|
|
||
| class PosixSequentialFile : public SequentialFile { | ||
| private: |
There was a problem hiding this comment.
一般都是把 private 放到 class 下面，你往下挪动下
AlexStocks
reviewed
Nov 27, 2023
| // file before reading from it, or for log files, the reading code | ||
| // knows enough to skip zero suffixes. | ||
| class PosixMmapFile : public WritableFile { | ||
| private: |
AlexStocks
reviewed
Nov 27, 2023
| return Status::OK(); | ||
| } | ||
|
|
||
| // virtual Status Allocate(off_t offset, off_t len) override { |
There was a problem hiding this comment.
pika里是这么做的，所以这里暂时跟它保持一致
AlexStocks
reviewed
Nov 27, 2023
src/pstd/pstd_status.h
Outdated
| @@ -0,0 +1,123 @@ | |||
| #ifndef __PSTD_STATUS_H__ | |||
There was a problem hiding this comment.
1 改成 #pragma once; 2 在开头加上 license 声明
AlexStocks
reviewed
Nov 27, 2023
| // LICENSE file in the root directory of this source tree. An additional grant | ||
| // of patent rights can be found in the PATENTS file in the same directory. | ||
|
|
||
| #ifndef INCLUDE_STORAGE_VERSION_H_ |
AlexStocks
reviewed
Nov 27, 2023
| // LICENSE file in the root directory of this source tree. An additional grant | ||
| // of patent rights can be found in the PATENTS file in the same directory. | ||
|
|
||
| #ifndef SRC_BASE_DATA_KEY_FORMAT_H_ |
Co-authored-by: wangxiaoxiong <[email protected]>
* fix string trim function crash * add gtest * add timestamp test,fix Random range error * Optimized trim function,add TrimLeft and TrimRight * fix StringTrimRight range error * Resolve rocksdb and gtest dependency conflicts * fix rocksdb and gtest dependency conflicts,Streamlined rocksdb compilation
…n#40) * complete string appendcmd getsetcmd * complete string mset & mget cmd * fixed some bugs * complete string bitcount cmd * fixed some bugs * five cmd pass simple demo test * feat:fixed some comments
github-actions
bot
added
the
📒 Documentation
This reverts commit d3dc4fd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.