Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rocksdb): add rocksdb instance to compile #46

Merged
merged 1 commit into from
Nov 21, 2023
Merged

feat(rocksdb): add rocksdb instance to compile #46

merged 1 commit into from
Nov 21, 2023

Conversation

Centurybbx
Copy link
Collaborator

AlexStocks
AlexStocks reviewed Nov 21, 2023
View reviewed changes
src/pikiwidb.cc
@@ -292,6 +293,7 @@ static void InitLogs() {
}

int main(int ac, char* av[]) {
[[maybe_unused]] rocksdb::DB* db;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加这么一个没用的变量，是何意啊？

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

先引入用来测试一下编译有没有问题，后面会把这个去掉

@AlexStocks AlexStocks merged commit bf3368c into OpenAtomFoundation:unstable Nov 21, 2023
1 check passed
@Centurybbx Centurybbx deleted the rocksdb-build branch November 21, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexStocks AlexStocks AlexStocks approved these changes

@panlei-coder panlei-coder panlei-coder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Centurybbx @AlexStocks @panlei-coder