feat: add gtest, fix string trim function crash #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
加上单测？ |
GTest那套吗 |
AlexStocks
previously approved these changes
Nov 17, 2023
你看吧，能加就加，不能加就以后再说。 |
我周末看一下, 好加的话 就加了 |
lqxhub
changed the title
|
加入 GTest 单测, 添加部分测试用例, 修复 现在单测还没有集成到 GitHub CI中, 下一步再集成到 GitHub CI中 |
AlexStocks
previously approved these changes
Nov 20, 2023
panlei-coder
previously approved these changes
Nov 20, 2023
loveyacper
reviewed
Nov 20, 2023
AlexStocks
previously approved these changes
Nov 20, 2023
Centurybbx
reviewed
Nov 20, 2023
src/pstd/pstd_string.cc
Outdated
| } | ||
| return ori.substr(pos, rpos - pos + 1); | ||
| return std::move(ori.substr(begin, ori.size() - begin)); |
There was a problem hiding this comment.
这里的std::move应该是不必要的吧，编译器会通过RVO来处理返回的值
There was a problem hiding this comment.
编译器应该是可以自动优化的, 但是我之前问gpt, 跟我说了一堆东西, 我不放心 就把 move加上了, 等明天我再确认一下
There was a problem hiding this comment.
这里的std::move应该是不必要的吧，编译器会通过RVO来处理返回的值
编译器确实可以自动使用RVO优化, 没有必要move 👍👍
loveyacper
reviewed
Nov 21, 2023
loveyacper
previously approved these changes
Nov 22, 2023
|
macos CI 还是失败了 |
今天早上发现有冲突了, 在网页上解了没弄好, 又个文件没弄过来,等晚上回去弄一下 |
github-actions
bot
added
☢️ Bug
Centurybbx
previously approved these changes
Nov 22, 2023
|
还有问题, rocksdb中依赖了gtest, 项目引入的gtest冲突了, 原本以为改一下rocksdb的cmake能解决, 测试了一下, 那样只是没有编译rocksdb, 实际还是没有解决这个依赖冲突问题 |
lqxhub
changed the title
Centurybbx
approved these changes
Nov 23, 2023
AlexStocks
approved these changes
Nov 25, 2023
Centurybbx
pushed a commit
to Centurybbx/pikiwidb
that referenced
this pull request
Nov 27, 2023
* fix string trim function crash * add gtest * add timestamp test,fix Random range error * Optimized trim function,add TrimLeft and TrimRight * fix StringTrimRight range error * Resolve rocksdb and gtest dependency conflicts * fix rocksdb and gtest dependency conflicts,Streamlined rocksdb compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复 pstd::StringTrim 函数 可能出现的崩溃