Modify the function return value,rename function name #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centurybbx
previously approved these changes
Nov 13, 2023
AlexStocks
reviewed
Nov 14, 2023
src/client.cc
Outdated
| @@ -520,7 +520,7 @@ bool PClient::isPeerMaster() const { | |||
| return repl_addr.GetIP() == PeerIP() && repl_addr.GetPort() == PeerPort(); | |||
| } | |||
|
|
|||
| int PClient::UniqueId() const { | |||
| int PClient::uniqueId() const { | |||
There was a problem hiding this comment.
注意一个常识：ID HTTP TCP UDP 这些专有名词，统统大写，不要写出 Id Http 这种词
panlei-coder
approved these changes
Nov 15, 2023
Centurybbx
approved these changes
Nov 15, 2023
AlexStocks
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修改
Message函数的返回值类型, 对执行命令的函数重命名