improvement(hashmap): use folly ConcurrentHashMap replace unordered_map #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Centurybbx
commented
Nov 4, 2023
Centurybbx
commented
- 多线程改造：使用folly::ConcurrentHashMap来替换std::unordered_map
- Work in progress...
Centurybbx
changed the title
AlexStocks
reviewed
Nov 7, 2023
| clients.push_back(Clients::value_type(std::static_pointer_cast<PClient>(client->shared_from_this()), timeout, pos)); | ||
| auto it = blockedClients_.find(key); | ||
| if (it != blockedClients_.end()) { | ||
| // since folly doesn't support modify value directly, we have to make a copy to update atomically |
There was a problem hiding this comment.
迭代器是一个不可变量；此外在官方的示例中，如果当前线程获取了某个迭代器，其余线程的更改对于当前线程是感知不到的，因此我认为是线程安全的
AlexStocks
previously approved these changes
Nov 7, 2023
lqxhub
reviewed
Nov 7, 2023
src/helper.h
Outdated
| } | ||
|
|
||
| it = container.cbegin(); | ||
| size_t randomIdx = random() % container.size(); |
There was a problem hiding this comment.
这里随机函数推荐使用 C++的随机函数, 像这里的
pikiwidb/src/pstd/pstd_string.cc
Line 409 in e05878d
这里我的锅, 在移植 pstd的时候, 没有把 随机函数 单独 包装好
panlei-coder
reviewed
Nov 7, 2023
src/store.cc
Outdated
| @@ -200,7 +210,7 @@ size_t PStore::BlockedClients::UnblockClient(PClient* client) { | |||
| const auto& keys = client->WaitingKeys(); | |||
|
|
|||
| for (const auto& key : keys) { | |||
| Clients& clients = blockedClients_[key]; | |||
| Clients clients = blockedClients_[key]; | |||
panlei-coder
approved these changes
Nov 8, 2023
lqxhub
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.