Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce folly to use concurrent hash map further #20

Merged
merged 2 commits into from
Oct 31, 2023
Merged

introduce folly to use concurrent hash map further #20

merged 2 commits into from
Oct 31, 2023

Conversation

tedli
Copy link
Contributor

@tedli tedli commented Oct 20, 2023 •
edited
Loading

引入 concurrent hash map

@tedli tedli marked this pull request as draft October 20, 2023 12:22
@tedli
Copy link
Contributor Author

tedli commented Oct 20, 2023 •
edited
Loading

https://github.com/tedli/dive-folly

这个工程可以独立编译链接

少文件，示例工程，不额外维护了。

@tedli tedli marked this pull request as ready for review October 23, 2023 03:17
@tedli tedli marked this pull request as draft October 23, 2023 09:57
@tedli tedli marked this pull request as ready for review October 23, 2023 10:12
panlei-coder
panlei-coder reviewed Oct 24, 2023
View reviewed changes
src/pikiwidb.cc Outdated Show resolved Hide resolved
panlei-coder
panlei-coder reviewed Oct 24, 2023
View reviewed changes
cmake/gflags.cmake Outdated Show resolved Hide resolved
Centurybbx
Centurybbx reviewed Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@Centurybbx Centurybbx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mac下glog替换没问题了，但是在链接时出现了一些新的问题：

  • pikiwidb/build/_deps/pikiwidb-folly-src/folly/Demangle.cpp:80:52: error: unknown type name 'demangle_callbackref' rust_demangle_callback_fallback(const char *, int, demangle_callbackref,
  • pikiwidb/build/_deps/pikiwidb-folly-src/folly/Demangle.cpp:117:5: error: use of undeclared identifier 'DMGL_PARAMS'

看起来是环境问题，在mac环境下它链接时会走Demangle.cpp中72～120行；而wsl下则没这个问题，麻烦再看下什么问题吧🚀

@tedli
Copy link
Contributor Author

tedli commented Oct 30, 2023

@Centurybbx hi，
又推上去一版，麻烦再帮试试。

@Centurybbx
Copy link
Collaborator

@Centurybbx hi， 又推上去一版，麻烦再帮试试。

Nice work！
我这次试了下，没有之前的问题了。但是在编译结束最后链接pikiwidb执行文件时会有以下情况：
image

可能是我本机环境的问题，等GitHub actions配好后用标准的机器试下后再处理吧

@tedli
Copy link
Contributor Author

tedli commented Oct 30, 2023

@Centurybbx hi,
image
帮试试 cmake 里加一下链接参数。或者改 build.sh 里，加上 -DCMAKE_EXE_LINKER_FLAGS="-stdlib=libc++ -lc++ -lc++abi"

@Centurybbx
Copy link
Collaborator

@Centurybbx hi, image 帮试试 cmake 里加一下链接参数。或者改 build.sh 里，加上 -DCMAKE_EXE_LINKER_FLAGS="-stdlib=libc++ -lc++ -lc++abi"

解决了！mac上应该没有别的问题了

@tedli tedli requested a review from Centurybbx October 30, 2023 06:33
Centurybbx
Centurybbx previously approved these changes Oct 30, 2023
View reviewed changes
@AlexStocks
Copy link
Collaborator

image

I got the above error when I exec 'sh build.sh'.

@AlexStocks AlexStocks merged commit ad3dca9 into OpenAtomFoundation:unstable Oct 31, 2023
1 check passed
@dingxiaoshuai123 dingxiaoshuai123 mentioned this pull request Apr 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexStocks AlexStocks AlexStocks approved these changes

@panlei-coder panlei-coder panlei-coder approved these changes

@Centurybbx Centurybbx Centurybbx left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tedli @Centurybbx @AlexStocks @panlei-coder