-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove calculateRequestOrder Function and fix bug #19685
base: master
Are you sure you want to change the base?
Remove calculateRequestOrder Function and fix bug #19685
Conversation
This PR removes the calculateRequestOrder function from the codebase and addresses the bug described in issue OpenAPITools#19110. After a thorough review, it was determined that the function was unnecessary due to its redundant logic and lack of unique functionality.
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
cc @mostafa |
…/github.com/DevMrRober/openapi-generator into fix/remove-calculateRequestOrder-issue19110
This PR removes the calculateRequestOrder function from the codebase and addresses the bug described in issue OpenAPITools#19110. After a thorough review, it was determined that the function was unnecessary due to its redundant logic and lack of unique functionality.
…/github.com/DevMrRober/openapi-generator into fix/remove-calculateRequestOrder-issue19110
Sorry, I made a mistake the first time, it should be right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your contribution.
Summary
This PR removes the
calculateRequestOrder
function. The previous function was deemed unnecessary due to its redundant logic and lack of unique functionality.Changes made
Removed function
Removed call to
calculateRequestOrder
function, which calculated the order of requests based onoperationGroupingOrder
andrequestsSize
.Updated request creation logic:
requests.size()
as the key inrequests.putIfAbsent()
, ensuring that each new request is added with a unique identifier based on the current size of the request map.Reason for change
Tests
Related issue
Reviewers
Translated with DeepL.com (free version)