Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in case of defined status codes > 299 switch will have no effect. issue 7788 #19483

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kruegge82
Copy link

@kruegge82 kruegge82 commented Aug 29, 2024

…described in issue 7788

so we get only an error if statusCode is not defined AND not between 200 and 299

#7788

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

…described in issue 7788

so we get only an error if statusCode is not defined AND not between 200 and 299

OpenAPITools#7788
@kruegge82
Copy link
Author

have i anything todo for implement into the master branch or wil it implemented with next version?

@wing328
Copy link
Member

wing328 commented Sep 16, 2024

@kruegge82 thanks for the PR

please follow step 3 to update the samples so that CI can verify the change

Copy link
Author

@kruegge82 kruegge82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not sure which step 3? i have not change files after PR...

…described in issue 7788

so we get only an error if statusCode is not defined AND not between 200 and 299

OpenAPITools#7788
@wing328
Copy link
Member

wing328 commented Sep 18, 2024

cc
@jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ybelenko (2018/07), @renepardon (2018/12)

@kruegge82
Copy link
Author

have i anything more todo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants