Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kotlin] Fix invalid gradlew.bat templates #19165

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

takkiraz
Copy link
Contributor

@takkiraz takkiraz commented Jul 15, 2024

Fixes #19163

This PR fixes the gradlew.bat file generated as a Unix Bash script instead of a Windows Batch file. The update corrects the template to generate a valid Batch script for proper execution on Windows.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jimschubert @andrewemery @alisters @stefankoppier

@takkiraz takkiraz changed the title Fix invalid gradlew.bat templates [Kotlin] Fix invalid gradlew.bat templates Jul 15, 2024
@wing328
Copy link
Member

wing328 commented Jul 15, 2024

lgtm. thanks for the PR

@wing328 wing328 merged commit 7f01a35 into OpenAPITools:master Jul 15, 2024
78 checks passed
@takkiraz takkiraz deleted the fix/gradle-wrapper-bat branch July 15, 2024 12:59
@wing328 wing328 added this to the 7.8.0 milestone Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Kotlin] gradlew.bat is not a valid batch file
2 participants