Build vignettes and Include tests in Binary packages

[Felixmil]

closes Open-Systems-Pharmacology/OSPSuite-R#1479
closes Open-Systems-Pharmacology/OSPSuite-R#1478

[Yuri05]

should we change the step

     - uses: r-lib/actions/check-r-package@v2
        with:
          upload-snapshots: true
          build_args: 'c("--no-manual","--compact-vignettes=gs+qpdf")'
          error-on: 'c("error")'

to

     - uses: r-lib/actions/check-r-package@v2
        with:
          upload-snapshots: true
          args: 'c("--no-manual", "--as-cran", "--no-vignettes")'
          build_args: 'c("--no-manual", "--no-build-vignettes")'
          error-on: 'c("error")'

?

Because now vignettes are first built/checked in this step and then are rebuilt again in the next step.

[Yuri05]

s. also #34

[Felixmil]

I think it's better to make the process fail faster in case something is wrong in the vignette.

[Yuri05]

The question for me is what's the more often use case: vignettes contain errors, or vignettes contain no errors?

I think "vignettes contain no errors" would be mostly the case, because the vignettes are modified not as often as the code and ideally a developer should test a modified vignette locally before committing. And then having vignettes built/checked only once would save more time overall.

[Felixmil]

Ok, I agree and changed the workflow accordingly.

[Yuri05]

@Felixmil Also maybe you could address the issue Open-Systems-Pharmacology/OSPSuite-R#1477 in this PR?

[Felixmil]

@Felixmil Also maybe you could address the issue Open-Systems-Pharmacology/OSPSuite-R#1477 in this PR?

This was done in Open-Systems-Pharmacology/OSPSuite-R#1481 as a repo-specific setting.

[Yuri05]

This was done in Open-Systems-Pharmacology/OSPSuite-R#1481 as a repo-specific setting.

Great! 👍