Fixes #67 Remove TODOs and create actual issues #1193
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
34 TODOs were identified and removed
configuration-plan.R
resizing of the input was fixed intlf
error-checks.R
replace the function name can be removed (logging wrapper around function used instead)gof-plot-task.R
group outputs in goodness of fit plots by uniquegroupID
once introduced - now described in issue Group outputs in goodness of fit plots by uniquegroupID
#1188qualification-gof.R
handling of LLOQ is already described in a dedicated issue Integration of LLOQ in Qualification Plots #1043qualification-pk-ratio.R
now described in Functions that may be more appropriate in{tlf}
#1192qualification-time-profile.R
error handling now described in issue Provide better error message when Molecular Weight is required in qualification time profiles #1189reportingengine-env.R
in case re theme is not found use tlf theme from themes folder (fixed in current PR)reportingengine-env.R
now described in Functions that may be more appropriate in{tlf}
#1192task.R
obsolete, no update needed withlogCatch()
task-results.R
deprecate the condition for null values is obsoletetask-results.R
{showtext}
hook may be redundant but ensures tlf settings are not alteredutilities-demography.R
now described in Functions that may be more appropriate in{tlf}
#1192utilities-goodness-of-fit.R
already described in issue Implement log residuals in the same way as in PK-Sim/MoBi #942utilities-goodness-of-fit.R
use dplyr to refactor the selection not necessaryutilities-goodness-of-fit.R
use dplyr to refactor the selection not necessaryutilities-goodness-of-fit.R
already described in tlf issue #369utilities-mpi-error-handling.R
now described in mpi verify functions should be renamed with validate and placed inerror-check.R
for consistency #1190utilities-plots.R
obsolete since line break algo works appropriatelyutilities-plots.R
now described in Functions that may be more appropriate in{tlf}
#1192utilities-plots.R
now described in Functions that may be more appropriate in{tlf}
#1192utilities-qualification.R
obsolete outputs and pk parameters are defined in the looputilities-qualification.R
QualificationPlotTypes
not used and removed in current PRutilities-ratio-comparison.R
now described in Functions that may be more appropriate in{tlf}
#1192utilities-task.R
obsolete, no update needed withlogCatch()
utilities-task.R
obsolete, no update needed withlogCatch()
utilities-task.R
obsolete, no update needed withlogCatch()
utilities-task.R
obsolete, no update needed withlogCatch()
utilities-task.R
now described in Include observed data files in Qualification Task input files #1191utilities-task.R
now described in Include observed data files in Qualification Task input files #1191utilities-task.R
now described in Include observed data files in Qualification Task input files #1191utilities-task.R
now described in Include observed data files in Qualification Task input files #1191utilities-task.R
now described in Include observed data files in Qualification Task input files #1191utils.R
now described in Functions that may be more appropriate in{tlf}
#1192