Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support axis keyword in array_contains #152

Merged
merged 4 commits into from
Aug 18, 2023

Conversation

LukeWeidenwalker
Copy link
Contributor

@LukeWeidenwalker LukeWeidenwalker commented Aug 16, 2023

Closes #63

@LukeWeidenwalker
Copy link
Contributor Author

@ValentinaHutter another small PR to have a look over please! :)

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #152 (447f3c8) into main (b1a1196) will increase coverage by 0.19%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
+ Coverage   78.75%   78.95%   +0.19%     
==========================================
  Files          27       28       +1     
  Lines        1177     1207      +30     
==========================================
+ Hits          927      953      +26     
- Misses        250      254       +4     
Files Changed Coverage Δ
...o_processes_dask/process_implementations/arrays.py 90.74% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@ValentinaHutter ValentinaHutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think, since array_contains is labeled as a reducer, it might be useful to add a small test to run reduce_dimension(reducer=array_contains).

def test_array_contains_axis():
data = np.array([[4, 5, 6], [5, 7, 9]])
result = array_contains(data, 5, axis=1)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test does not have an assert, yet.

@LukeWeidenwalker
Copy link
Contributor Author

Ah, good points - fixed both, thanks! :)

@LukeWeidenwalker LukeWeidenwalker merged commit c4aacb2 into main Aug 18, 2023
5 checks passed
@LukeWeidenwalker LukeWeidenwalker deleted the array_contains-add-axis-keyword branch August 18, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support axis keyword for array_contains
2 participants