-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to spring boot 2.6.X #115
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh this is already merged ;)
<relativePath/> <!-- lookup parent from repository --> | ||
</parent> | ||
|
||
<properties> | ||
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hehe I think this whitespace is not needed ;)
<scope>test</scope> | ||
<version>${powermock-module-junit4.version}</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could also remove the proberties for the not used dependencies
consultingTypeLoader, "consultingTypeRepositoryService", consultingTypeRepositoryService); | ||
} | ||
|
||
@Test | ||
public void test_Should_Fail_WhenMethodInitDoesNotHavePostConstructAnnotation() | ||
void test_Should_Fail_WhenMethodInitDoesNotHavePostConstructAnnotation() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know it by heart right now, but now some test methods are public others are package-private. Shouldn't we standardise this more? Or what is the pattern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the tests we switched to junit5, there should be no public test methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but I saw a lot of tests using junit5 but the test mothods still public etc.
https://github.com/Onlineberatung/onlineBeratung-consultingTypeService/pull/115/files#diff-91bf97d4b3a3c619f25e6c17e009a271f185fd9342b7ae6202ceba7e7014e44b
Fixes #
Proposed Changes