Fix: issue 625

OBAKit/Agencies/AgenciesViewController.swift

@@ -14,14 +14,18 @@ import OBAKitCore
 /// Loads and displays a list of agencies in the current region.
 class AgenciesViewController: TaskController<[AgencyWithCoverage]>, OBAListViewDataSource {
     let listView = OBAListView()
+
+    public override func loadView() {
+        super.loadView()
+        self.view = listView
+    }
 
     override func viewDidLoad() {
         super.viewDidLoad()
 
         view.backgroundColor = ThemeColors.shared.systemBackground
 
         listView.obaDataSource = self
-        view.addSubview(listView)
         listView.pinToSuperview(.edges)
 
         title = OBALoc("agencies_controller.title", value: "Agencies", comment: "Title of the Agencies controller")

OBAKit/Alerts/AgencyAlertsViewController.swift

@@ -49,6 +49,11 @@ class AgencyAlertsViewController: UIViewController,
     }
 
     // MARK: - UIViewController
+    public override func loadView() {
+        super.loadView()
+        self.view = listView
+    }
+
     public override func viewDidLoad() {
         super.viewDidLoad()
 
@@ -58,7 +63,6 @@ class AgencyAlertsViewController: UIViewController,
         listView.collapsibleSectionsDelegate = self
         listView.contextMenuDelegate = self
         listView.refreshControl = refreshControl
-        view.addSubview(listView)
         listView.pinToSuperview(.edges)
 
         view.backgroundColor = ThemeColors.shared.systemBackground

OBAKit/Bookmarks/AddBookmarkViewController.swift

@@ -40,13 +40,16 @@ class AddBookmarkViewController: TaskController<[ArrivalDeparture]>, OBAListView
     }
 
     // MARK: - UIViewController
+    public override func loadView() {
+        super.loadView()
+        self.view = listView
+    }
 
     public override func viewDidLoad() {
         super.viewDidLoad()
 
         view.backgroundColor = ThemeColors.shared.systemBackground
         listView.obaDataSource = self
-        view.addSubview(listView)
         listView.pinToSuperview(.edges)
     }
 

OBAKit/Bookmarks/BookmarksViewController.swift

@@ -91,6 +91,11 @@ public class BookmarksViewController: UIViewController,
     }
 
     // MARK: - UIViewController
+    public override func loadView() {
+        super.loadView()
+        self.view = listView
+    }
+
     public override func viewDidLoad() {
         super.viewDidLoad()
 
@@ -100,7 +105,6 @@ public class BookmarksViewController: UIViewController,
         listView.contextMenuDelegate = self
         listView.formatters = application.formatters
         listView.register(listViewItem: BookmarkArrivalViewModel.self)
-        view.addSubview(listView)
         listView.pinToSuperview(.edges)
 
         rebuildSortMenu()

OBAKit/Orchestration/Application.swift

@@ -348,6 +348,7 @@ public class Application: CoreApplication, PushServiceDelegate {
         reloadRootUserInterface()
 
         reportAnalyticsUserProperties()
+        UIApplication.shared.delegate?.window??.windowScene?.screenshotService?.delegate = self
     }
 
     @objc public func applicationDidBecomeActive(_ application: UIApplication) {
@@ -589,3 +590,33 @@ public class Application: CoreApplication, PushServiceDelegate {
     /// `.running` means that the feature is ready to use.
     public lazy var features = FeatureAvailability(config: self.config, application: self)
 }
+
+// MARK: UIScreenshotServiceDelegate
+extension Application: UIScreenshotServiceDelegate {
+    public func screenshotService(_ screenshotService: UIScreenshotService, generatePDFRepresentationWithCompletion completionHandler: @escaping (Data?, Int, CGRect) -> Void) {
+        guard let topVC = UIApplication.shared.keyWindowFromScene?.topViewController,
+              let scrollerView = topVC.view as? OBAListView,
+              scrollerView.contentSize.height != .zero else {
+            completionHandler(nil, 0, .zero)
+            return
+        }
+        let data = NSMutableData()
+        UIGraphicsBeginPDFContextToData(data, .zero, nil)
+        UIGraphicsBeginPDFPageWithInfo(.init(origin: .zero, size: scrollerView.contentSize), nil)
+        if let context = UIGraphicsGetCurrentContext() {
+            let frame = scrollerView.frame
+            let contentOffset = scrollerView.contentOffset
+            let contentInset = scrollerView.contentInset
+            scrollerView.contentOffset = .zero
+            scrollerView.contentInset = .zero
+            scrollerView.frame = .init(origin: .zero, size: scrollerView.contentSize)
+            scrollerView.layer.render(in: context)
+            scrollerView.frame = frame
+            scrollerView.contentOffset = contentOffset
+            scrollerView.contentInset = contentInset
+        }
+        UIGraphicsEndPDFContext()
+        let y = scrollerView.contentSize.height - scrollerView.contentOffset.y - scrollerView.frame.height
+        completionHandler(data as Data, 0, .init(origin: CGPoint(x: 0, y: y), size: topVC.view.frame.size))
+    }
+}

OBAKit/Recent/RecentStopsViewController.swift

@@ -37,14 +37,17 @@ public class RecentStopsViewController: UIViewController,
     }
 
     // MARK: - UIViewController
+    public override func loadView() {
+        super.loadView()
+        self.view = listView
+    }
 
     public override func viewDidLoad() {
         super.viewDidLoad()
 
         navigationItem.rightBarButtonItem = UIBarButtonItem(title: OBALoc("recent_stops.delete_all", value: "Delete All", comment: "A button that deletes all of the recent stops in the app."), style: .plain, target: self, action: #selector(deleteAll))
 
         view.backgroundColor = ThemeColors.shared.systemBackground
-        view.addSubview(listView)
         listView.contextMenuDelegate = self
         listView.pinToSuperview(.edges)
     }

OBAKit/Reporting/ReportProblemViewController.swift

@@ -40,6 +40,10 @@ class ReportProblemViewController: TaskController<StopArrivals>,
     required init?(coder: NSCoder) { fatalError("init(coder:) has not been implemented") }
 
     // MARK: - UIViewController
+    public override func loadView() {
+        super.loadView()
+        self.view = listView
+    }
 
     public override func viewDidLoad() {
         super.viewDidLoad()
@@ -50,7 +54,6 @@ class ReportProblemViewController: TaskController<StopArrivals>,
         listView.formatters = application.formatters
         listView.register(listViewItem: ArrivalDepartureItem.self)
 
-        view.addSubview(listView)
         listView.pinToSuperview(.edges)
     }
 

OBAKit/Search/SearchResultsController.swift

@@ -34,13 +34,16 @@ public class SearchResultsController: UIViewController, AppContext, OBAListViewD
         titleView.subtitleLabel.text = subtitleText(from: searchResponse)
 
         listView.obaDataSource = self
-        view.addSubview(listView)
         listView.pinToSuperview(.edges)
     }
 
     required init?(coder aDecoder: NSCoder) { fatalError("init(coder:) has not been implemented") }
 
     // MARK: - UIViewController Lifecycle
+    public override func loadView() {
+        super.loadView()
+        self.view = listView
+    }
 
     override public func viewDidLoad() {
         super.viewDidLoad()

OBAKit/ServiceAlerts/ServiceAlertListController.swift

@@ -34,14 +34,17 @@ final class ServiceAlertListController: UIViewController,
     }
 
     // MARK: - UIViewController
+    public override func loadView() {
+        super.loadView()
+        self.view = listView
+    }
 
     override func viewDidLoad() {
         super.viewDidLoad()
 
         view.backgroundColor = ThemeColors.shared.systemBackground
 
         listView.obaDataSource = self
-        view.addSubview(listView)
         listView.pinToSuperview(.edges)
     }
 

OBAKit/Settings/CreditsViewController.swift

@@ -36,13 +36,16 @@ class CreditsViewController: UIViewController, AppContext, OBAListViewDataSource
     }
 
     // MARK: - UIViewController
+    public override func loadView() {
+        super.loadView()
+        self.view = listView
+    }
 
     override func viewDidLoad() {
         super.viewDidLoad()
 
         view.backgroundColor = ThemeColors.shared.systemBackground
 
-        view.addSubview(listView)
         listView.pinToSuperview(.edges)
         listView.obaDataSource = self
         listView.applyData()

OBAKit/Settings/MoreViewController.swift

@@ -51,11 +51,14 @@ public class MoreViewController: UIViewController,
     }
 
     // MARK: - UIViewController
+    public override func loadView() {
+        super.loadView()
+        self.view = listView
+    }
     public override func viewDidLoad() {
         super.viewDidLoad()
 
         listView.obaDataSource = self
-        view.addSubview(listView)
         listView.pinToSuperview(.edges)
 
         view.backgroundColor = ThemeColors.shared.systemBackground

OBAKit/Stops/NearbyStopsViewController.swift

@@ -44,6 +44,10 @@ class NearbyStopsViewController: UIViewController,
     required init?(coder aDecoder: NSCoder) { fatalError("init(coder:) has not been implemented") }
 
     // MARK: - UIViewController
+    public override func loadView() {
+        super.loadView()
+        self.view = listView
+    }
 
     public override func viewDidLoad() {
         super.viewDidLoad()

OBAKit/Stops/StopViewController.swift

@@ -166,6 +166,10 @@ public class StopViewController: UIViewController,
     }
 
     // MARK: - UIViewController Overrides
+    public override func loadView() {
+        super.loadView()
+        self.view = listView
+    }
 
     public override func viewDidLoad() {
         super.viewDidLoad()
@@ -185,7 +189,6 @@ public class StopViewController: UIViewController,
         listView.register(listViewItem: StopArrivalWalkItem.self)
         listView.register(listViewItem: StopHeaderItem.self)
 
-        view.addSubview(listView)
         listView.pinToSuperview(.edges)
         listView.addSubview(refreshControl)
 

OBAKit/Trip/TripFloatingPanelController.swift

@@ -68,6 +68,10 @@ class TripFloatingPanelController: UIViewController,
     required init?(coder: NSCoder) { fatalError("init(coder:) has not been implemented") }
 
     // MARK: - UIViewController
+    public override func loadView() {
+        super.loadView()
+        self.view = listView
+    }
 
     public override func viewDidLoad() {
         super.viewDidLoad()
@@ -79,7 +83,6 @@ class TripFloatingPanelController: UIViewController,
         listView.register(listViewItem: TripStopViewModel.self)
 
         view.backgroundColor = ThemeColors.shared.systemBackground
-        view.addSubview(outerStack)
         outerStack.pinToSuperview(.edges)
     }