Add signal property to pin Connectors #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to enable future re-use and potential modification of ID format.
…oles. The intention was that Connector names should only be generated for pins/pads but it turned out we were also generating names (which were invalid, e.g. "S1.null") for mechanical holes. This fix ensures names are only generated for pins/pads connectors. (This fix should really be made on the parent of this branch.)
This work will enable us to expose a property for each connector that indicates what signal (i.e. net) is connected to the pin.
(Per #40.) Exposes a property (`.userData.signal`) for each pin Connector with the name (as a string) of the signal (i.e. net) which is connected to the pin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #40.