New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check memberships are fetched on account deletion #3125

Merged

tzarebczan merged 3 commits into OdyseeTeam:master from keikari:membership-fetching-success-check

Jul 26, 2024

Contributor

keikari commented Jul 26, 2024 •

edited

Loading

Behavior after changes:

adds check for that memberships are fetched on account deletion (these should be fetched on page load)
if fetching memberships fails -> consider memberships not fetched
- also fixes infinite loading on premium and donor page caused by the above change
  Note: Commits say "infinite loop", but meant infinite loading
empty membership data on successful fetch is still considered as fetched

Images

miko added 3 commits

July 26, 2024 14:14


          Check if memberships are fetched on account deletion flow

2b84859

+ Consider failed fetch as memberships not fetched


          Fix infinite loop on premium page when membership/mine fails

2d5ee4f


          Fix infinite loop on donor page when membership/mine fails + appstring

07e8981

tzarebczan merged commit 2a45ce6 into OdyseeTeam:master

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet