Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing some errors in the release workflow #47

Merged
merged 33 commits into from
Sep 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
567de39
Correct release workflow error
MohamedNasser8 Aug 30, 2024
f086836
remove branch from workflow
MohamedNasser8 Aug 30, 2024
f4e75c2
Added repository option[testpypi, pypi], Added user info
MohamedNasser8 Aug 31, 2024
24d9f67
Bump version to major
MohamedNasser8 Aug 31, 2024
071b50e
use poetry instead of python
MohamedNasser8 Aug 31, 2024
a10d548
Bump version to major
MohamedNasser8 Aug 31, 2024
340281d
Merge branch 'sematic-version' of https://github.com/OSIPI/osipi into…
MohamedNasser8 Aug 31, 2024
3123d1e
Update release.yaml
MohamedNasser8 Aug 31, 2024
959e40f
Update release.yaml
MohamedNasser8 Aug 31, 2024
1a613c5
Bump version to major
MohamedNasser8 Aug 31, 2024
1a7786a
Bump version to minor
ltorres6 Sep 4, 2024
97d5dd5
Bump version to patch
ltorres6 Sep 4, 2024
c274cbd
Bump version to major
ltorres6 Sep 4, 2024
c004d64
Added releases
MohamedNasser8 Sep 5, 2024
f1a2c34
Bump version to minor
MohamedNasser8 Sep 5, 2024
cf60581
fix workflow error
MohamedNasser8 Sep 5, 2024
cd8a219
Bump version to 0.3.0
MohamedNasser8 Sep 5, 2024
1899af4
missing "
MohamedNasser8 Sep 5, 2024
29d9601
Bump version to 0.3.1
MohamedNasser8 Sep 5, 2024
cc9ff09
Update release.yaml
MohamedNasser8 Sep 5, 2024
2c78424
Bump version to 0.3.2
MohamedNasser8 Sep 5, 2024
4326adb
auto generated release notes
MohamedNasser8 Sep 5, 2024
1c628d9
Update release.yaml
MohamedNasser8 Sep 5, 2024
45d4282
Bump version to 0.3.3
MohamedNasser8 Sep 5, 2024
bdd57e3
Update release.yaml
MohamedNasser8 Sep 6, 2024
ca2c8dd
Bump version to 0.3.4
MohamedNasser8 Sep 6, 2024
c699d48
Update release.yaml
MohamedNasser8 Sep 6, 2024
3e95e12
Bump version to 0.3.5
MohamedNasser8 Sep 6, 2024
3b6f2dd
Bump version to 0.3.6
ltorres6 Sep 8, 2024
8506b9e
Bump version to 0.3.7
ltorres6 Sep 9, 2024
779706d
Remove release drafter, it's already on main
MohamedNasser8 Sep 9, 2024
c24365f
Bump version to 1.0.0
ltorres6 Sep 9, 2024
52e1c75
reset version release
ltorres6 Sep 9, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 54 additions & 8 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ name: Publish to PyPI

on:
workflow_dispatch:
branches:
- main
inputs:
version:
description: 'Version to release'
Expand All @@ -16,6 +14,22 @@ on:
- 'minor'
- 'patch'

repository:
description: 'Repository to publish to'
required: true
default: 'testpypi'
type: choice
options:
- 'pypi'
- 'testpypi'

permissions:
contents: write
id-token: write
pull-requests: read
issues: read


jobs:
release:
runs-on: ubuntu-latest
Expand All @@ -37,19 +51,51 @@ jobs:
run: poetry install

- name: Bump version
id: bump_version
run: |
python handle_versioning.py ${{ github.event.inputs.version }}
poetry run python handle_versioning.py ${{ github.event.inputs.version }}
git config user.name "${{ github.actor }}"
git config user.email "${{ github.actor }}@users.noreply.github.com"
git add pyproject.toml
git commit -m "Bump version to ${{ github.event.inputs.version }}"
new_version=$(poetry run python handle_versioning.py read)
git commit -m "Bump version to $new_version"
git push
echo "latest_version=$new_version" >> $GITHUB_ENV

- name: Generate release notes
id: release-notes
uses: release-drafter/release-drafter@v6
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Create tag
id: create_tags
run: |
current_version=$(python -c "import toml; print(toml.load('pyproject.toml')['tool']['poetry']['version'])")
current_version=${{env.latest_version}}
git tag $current_version
git push origin $current_version

- name: Publish to PyPI
- name: Create release
id: create_release
uses: actions/create-release@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
tag_name: ${{env.latest_version}}
release_name: Release ${{env.latest_version}}
body: ${{ steps.release-notes.outputs.release_notes }}
draft: false
prerelease: false

- name: Build package
run: |
poetry build

- name: Publish to TestPyPI or PyPI
uses: pypa/gh-action-pypi-publish@release/v1
with:
repository-url: ${{ github.event.inputs.repository == 'pypi' && 'https://upload.pypi.org/legacy/' || 'https://test.pypi.org/legacy/' }}
username: __token__
password: ${{ github.event.inputs.repository == 'pypi' && secrets.PYPI_API_TOKEN || secrets.TEST_PYPI_API_TOKEN }}
env:
POETRY_PYPI_TOKEN: ${{ secrets.POETRY_PYPI_TOKEN }}
run: poetry publish --build
POETRY_PYPI_TOKEN: ${{ github.event.inputs.repository == 'pypi' && secrets.PYPI_POETRY_TOKEN || secrets.TEST_PYPI_POETRY_TOKEN }}
2 changes: 1 addition & 1 deletion handle_versioning.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def bump_version(part):
command = sys.argv[1]
if command == "read":
current_version = read_version()
print(f"Current version is {current_version}")
print(f"{current_version}")

else:
bump_version(command)
4 changes: 1 addition & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ line-length = 100

[tool.poetry]
name = "osipi"
version = "0.1.2"
version = "0.1.0"
description = "The authorative python package for perfusion MRI"
authors = [ "Luis Torres <[email protected]>", "Steven Sourbron <[email protected]>",]
readme = "README.md"
Expand All @@ -47,9 +47,7 @@ quote-style = "double"
indent-style = "space"
skip-magic-trailing-comma = false
line-ending = "auto"

docstring-code-format = true

docstring-code-line-length = 100

[tool.poetry.dependencies]
Expand Down
Loading