Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry #32

Merged
merged 12 commits into from
Jun 20, 2024
Merged

Poetry #32

merged 12 commits into from
Jun 20, 2024

Conversation

MohamedNasser8
Copy link
Collaborator

This PR introduces Poetry as the dependency manager for our project and refactors the GitHub Actions workflow to use Poetry for linting and testing.

Changes include:

  • Adding poetry to pyproject.toml and poetry.lock for Poetry dependency management.
  • Updating the GitHub Actions workflow to install dependencies with Poetry.
  • Refactoring the linting and pytest steps to use Poetry.

How to Test

  1. Ensure that Poetry is installed locally.
  2. Run poetry install to install dependencies.
  3. Activate the Virtual Environment poetry shell
  4. To run the application poetry run file.py
  5. To run the tests, use: poetry run pytest

@ltorres6 ltorres6 marked this pull request as draft June 12, 2024 00:52
@ltorres6 ltorres6 closed this Jun 12, 2024
@ltorres6 ltorres6 reopened this Jun 12, 2024
Merge pull request #31 from OSIPI/formatting-and-lenting
Copy link
Collaborator

@ltorres6 ltorres6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments, but otherwise LGTM when you make those changes.

.github/workflows/lint.yaml Outdated Show resolved Hide resolved
junit/test-results.xml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@ltorres6 ltorres6 marked this pull request as ready for review June 12, 2024 01:08
@ltorres6 ltorres6 merged commit e475090 into main Jun 20, 2024
9 checks passed
@ltorres6 ltorres6 deleted the poetry branch August 8, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants