Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ERB.new to remove deprecation warnings #849

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

johrstrom
Copy link
Contributor

fix ERB.new to remove deprecation warnings.

The warnings in question are these 2:

/users/PZS0714/johrstrom/ondemand/misc/core/lib/ood_core/job/adapters/kubernetes/batch.rb:242: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.
/users/PZS0714/johrstrom/ondemand/misc/core/lib/ood_core/job/adapters/kubernetes/batch.rb:242: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.

Copy link
Contributor

@Oglopf Oglopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@johrstrom johrstrom merged commit 8d959b8 into master Aug 26, 2024
2 checks passed
@johrstrom johrstrom deleted the fix-erb-deprecations branch August 26, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants