Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test case for supporting instantaneous rates in extended network #1175

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Test case for supporting instantaneous rates in extended network #1175

merged 2 commits into from
Jun 10, 2024

Conversation

vkip
Copy link
Member

@vkip vkip commented Jun 5, 2024

GitPaean
GitPaean approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@GitPaean GitPaean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test case looks fine to me.

Maybe in the file name we can reflect that we are setting the item 3 to be 'NO' for WEFAC and GEFAC in case we have a test case later that using the default values ('YES') for these two keywords.

@GitPaean
Copy link
Member

Thanks for the update. It looks good to me now. I am getting it in.

@GitPaean GitPaean merged commit e19b42f into OPM:master Jun 10, 2024
@vkip vkip deleted the extnet_efficiency branch June 10, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitPaean GitPaean GitPaean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vkip @GitPaean