remove ebos_altidx #3428
remove ebos_altidx #3428
Conversation
building a whole simulator for this, and then not even running a test for it, seems rather excessive. if a test for index-conformance is wanted, a better approach should be taken.
|
jenkins build this please |
|
I'll give you review!
|
|
I think the purpose was to avoid error related to hard-coding of indices. From my point of view it can be removed. I really want to move to dynamic indices like what I started on in OPM/opm-models#631 that will also make this simulator absolute. Shouldn't be too much work to finish, but hasn't been on my agenda for a long time. Testing I did back than shows that using dynamic indices did not change the simulation time significantly, but will reduce the number of simulators to compile drastically. |
|
jenkins build this please |
|
It seems master is broken. MSW instabilities likely triggered by rebooting the machine. Gave us different hardware I guess.. |
|
jenkins build this update_data please |
Reason: OPM/opm-simulators#3428 opm-common = f17b75ab53687a09b9259f0c1b086672f53e0d23 opm-grid = 8034c7c94490d9003bddb306a596ec14218d9cb5 opm-material = 5863e98c3297e04a30154db29455b110df22a5ac opm-models = 4a6e46154e22d6aeb98bcbded312d6809d011772 opm-simulators = 1f1cd832f800ceb9508d15118fbb87e8c5e5d45f ### Changed Tests ### * msw_3d_hfa * msw_model_1 * faults_model_1 * 0a1_grpctl_msw_model2 * 0a2_grpctl_msw_model2 * 0a3_grpctl_msw_model2 * 0a4_grpctl_msw_model2 * 9_1a_grpctl_msw_model2 * 9_1b_grpctl_msw_model2 * 9_2a_grpctl_msw_model2 * 9_2b_grpctl_msw_model2 * 9_3a_grpctl_msw_model2 * 9_3b_grpctl_msw_model2 * 9_3c_grpctl_msw_model2 * 9_3d_grpctl_msw_model2 * 9_3e_grpctl_msw_model2 * 9_4a_grpctl_msw_model2 * 9_4b_grpctl_msw_model2 * 9_4c_grpctl_msw_model2 * 9_4d_grpctl_msw_model2 * model4_group * model4_udq_group * model6_msw * wsegsicd * wsegaicd
|
jenkins build this opm-tests=573 please |
Automatic Reference Data Update for PR OPM/opm-simulators#3428
|
jenkins build this please |
building a whole simulator for this, and then not even
running a test for it, seems rather excessive. if a test for
index-conformance is wanted, a better approach should be taken.
at least in my opinion..