Add WCD, GCDI, GCDM, WIPG, WIPL summary output for Field and Region #3408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this opm-simulators=4477 please |
bska
reviewed
Feb 22, 2023
src/opm/output/eclipse/Summary.cpp
Outdated
Comment on lines
2233
to
2235
| {"FGCDI" , Opm::UnitSystem::measure::liquid_surface_volume }, | ||
| {"FGCDM" , Opm::UnitSystem::measure::liquid_surface_volume }, | ||
| {"FWCD" , Opm::UnitSystem::measure::gas_surface_volume }, |
There was a problem hiding this comment.
This appears to use two different units of measurement for CO2, depending on whether it is in the gas phase (FG*) or in the water phase (FW*). Is that intentional?
src/opm/output/eclipse/Summary.cpp
Outdated
| {"FGCDM" , Opm::UnitSystem::measure::liquid_surface_volume }, | ||
| {"FWCD" , Opm::UnitSystem::measure::gas_surface_volume }, | ||
| {"FWIPG" , Opm::UnitSystem::measure::liquid_surface_volume }, | ||
| {"FWIPL" , Opm::UnitSystem::measure::liquid_surface_volume } |
There was a problem hiding this comment.
Tiny nit, but could you put a trailing comma on the last entry here please? That way, it's slightly easier to add new entries when we need to.
totto82
force-pushed
the
summary_co2store
branch
from
eb86278
to
7e6f757
Compare
totto82
force-pushed
the
summary_co2store
branch
from
7e6f757
to
89850ad
Compare
|
jenkins build this opm-simulators=4477 please |
|
|
|
Seems to work as expected. Results are from modified CO2STORE test case. OPM/opm-tests#910 |
bska
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are summary output that is used for CO2STORE simulations.