Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for loading only active cell geometry #11624

Merged
merged 13 commits into from
Aug 28, 2024
Merged

Support for loading only active cell geometry #11624

merged 13 commits into from
Aug 28, 2024

Conversation

jonjenssen
Copy link
Collaborator

@jonjenssen jonjenssen commented Aug 20, 2024

Closes #228

First version, LGR support disabled when loading only active cells

@magnesj magnesj marked this pull request as ready for review August 26, 2024 10:32
… simulation cell

When importing only active cells, this situation can occur if the well head or a well simulation cell is a inactive cell.

Seen in a test case from Martin Linge.
Copy link
Member

@magnesj magnesj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an issue with some findings #11640

@magnesj
Copy link
Member

magnesj commented Aug 28, 2024

I have tested on several cases of different sizes, and everything works as expected. I think this is ready for testing on Equinor grid models.

@magnesj magnesj self-requested a review August 28, 2024 14:22
@jonjenssen jonjenssen merged commit 0572069 into dev Aug 28, 2024
21 checks passed
@jonjenssen jonjenssen deleted the activecellgrid branch August 28, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import performance: Skip geometry for inactive cells
3 participants