Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Republish improvements #2468

Merged
merged 17 commits into from
Feb 27, 2024
Merged

Client Republish improvements #2468

merged 17 commits into from
Feb 27, 2024

Conversation

mregen
Copy link
Contributor

@mregen mregen commented Jan 19, 2024

Proposed changes

  • only republish available sequence numbers
  • store republish result to handle unsuccessful message republish in main loop
  • republish in parallel instead of sequential to reduce processing time

Related Issues

  • Fixes #

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 53.97%. Comparing base (a64c5a9) to head (84316fe).

Files Patch % Lines
Libraries/Opc.Ua.Client/Subscription.cs 96.42% 0 Missing and 1 partial ⚠️
...Opc.Ua.Core/Security/Constants/SecurityPolicies.cs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2468      +/-   ##
==========================================
+ Coverage   53.87%   53.97%   +0.10%     
==========================================
  Files         334      334              
  Lines       64455    64472      +17     
  Branches    13251    13253       +2     
==========================================
+ Hits        34726    34801      +75     
+ Misses      25968    25919      -49     
+ Partials     3761     3752       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EthanChangAED EthanChangAED added this to the 1.5.373 February Update milestone Feb 6, 2024
@mregen mregen marked this pull request as ready for review February 26, 2024 22:38
@mregen mregen merged commit 1b893b5 into master Feb 27, 2024
70 of 72 checks passed
@mregen mregen deleted the republish branch February 27, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants