-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(component): Adds flexible DataRow component WIP #4399
Open
dan-rukas
wants to merge
7
commits into
master
Choose a base branch
from
feat/data-row-protoype
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes initial prototype of a generic datarow component that can be used for measurements, segments, and other types of data
Lists duplicated to show a full width example and panel width example
✅ Deploy Preview for ohif-dev canceled.
|
✅ Deploy Preview for ohif-platform-docs canceled.
|
Viewers Run #4317
Run Properties:
|
Project |
Viewers
|
Branch Review |
feat/data-row-protoype
|
Run status |
Passed #4317
|
Run duration | 02m 39s |
Commit |
ab21b5e31f: Panel prototypes
|
Committer | Dan Rukas |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
2
|
Skipped |
0
|
Passing |
44
|
View all changes introduced in this branch ↗︎ |
Action icons are always visible on a selected row. Action icons stay visible after click as expected even on unselected rows.
Added Segmentation and Measurement panel prototypes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Adds a flexible DataRow component for consistent data presentation and interactions.
Features:
aria-labels
and ensures keyboard navigability for improved accessibility.Work in progress – additional refinements and thorough testing to follow.
Changes & Results
Adds DataRow component to ui-next (currently in prototypes)
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment