Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): Adds flexible DataRow component WIP #4399

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

dan-rukas
Copy link
Member

Context

Adds a flexible DataRow component for consistent data presentation and interactions.

Features:

  • Structured Data Display: Presents numbered rows with titles, descriptions, and optional color indicators for clear information hierarchy.
  • Action Menu: Integrates a DropdownMenu with the "More" icon for accessing contextual actions
  • Support for Multiple List Types: Handles various data presentation
  • Accessibility Enhancements: Implements descriptive aria-labels and ensures keyboard navigability for improved accessibility.
  • Responsive Design: Ensures consistent appearance and functionality across different screen sizes and devices.

Work in progress – additional refinements and thorough testing to follow.

Changes & Results

Adds DataRow component to ui-next (currently in prototypes)

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

Includes initial prototype of a generic datarow component that can be used for measurements, segments, and other types of data
Lists duplicated to show a full width example and panel width example
Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for ohif-dev canceled.

Name Link
🔨 Latest commit ab21b5e
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/66ffdb3afe8a2d0008db2907

Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for ohif-platform-docs canceled.

Name Link
🔨 Latest commit ab21b5e
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/66ffdb3a5160330008732660

Copy link

cypress bot commented Oct 2, 2024

Viewers    Run #4317

Run Properties:  status check passed Passed #4317  •  git commit ab21b5e31f: Panel prototypes
Project Viewers
Branch Review feat/data-row-protoype
Run status status check passed Passed #4317
Run duration 02m 39s
Commit git commit ab21b5e31f: Panel prototypes
Committer Dan Rukas
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 44
View all changes introduced in this branch ↗︎

Action icons are always visible on a selected row. Action icons stay visible after click as expected even on unselected rows.
Added Segmentation and Measurement panel prototypes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant