Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Select): select clear button #4398

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

pedrokohler
Copy link
Collaborator

Context

The ohif/ui select does not work if you try to clear the selection. The onChange function throws an error because it tries to select the length property of null:

image

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 2c9a79d
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/66fc25c302b9890008cd9570
😎 Deploy Preview https://deploy-preview-4398--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 2c9a79d
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/66fc25c3f34a3400083613f5
😎 Deploy Preview https://deploy-preview-4398--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pedrokohler pedrokohler changed the title fix: select clear button fix(ui): select clear button Oct 1, 2024
@pedrokohler pedrokohler changed the title fix(ui): select clear button fix(Select): select clear button Oct 1, 2024
@sedghi sedghi merged commit a11cd6d into OHIF:master Oct 1, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants