Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/cs3d 2 #4347

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat/cs3d 2 #4347

wants to merge 2 commits into from

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Aug 26, 2024

  • was not that hard migration at least for basic render nice
  • try cs3d 2.0 in master

Context

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

@sedghi
was not that hard migration at least for basic render nice
c1ebd7f 
chore: Enable stack context prefetch on new stack events

chore: Update measurement unit properties to match new naming conventions

chore: Update TypeScript dependency to version 5.5.4

chore: Update TypeScript dependency to version 5.5.4

chore: Fix typo in SegmentationService.ts
@sedghi
try cs3d 2.0 in master
3d483ab
@netlify Netlify
Copy link

netlify bot commented Aug 26, 2024 •
edited
Loading

❌ Deploy Preview for ohif-dev failed. Why did it fail? →

Name Link
🔨 Latest commit 3d483ab
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/66ccebcbc17f5e0008a5c7b5

@netlify Netlify
Copy link

netlify bot commented Aug 26, 2024 •
edited
Loading

❌ Deploy Preview for ohif-platform-docs failed. Why did it fail? →

Name Link
🔨 Latest commit 3d483ab
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/66ccebcbc2252a0008974273

@cypress Cypress
Copy link

cypress bot commented Aug 26, 2024

Viewers    Run #4237

Run Properties:  status check failed Failed #4237  •  git commit 3d483ab08f: try cs3d 2.0 in master
Project Viewers
Branch Review feat/cs3d-2
Run status status check failed Failed #4237
Run duration 03m 54s
Commit git commit 3d483ab08f: try cs3d 2.0 in master
Committer Alireza
View all properties for this run ↗︎
Test results
Tests that failed  Failures 14
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 28
Tests that passed  Passing 2
View all changes introduced in this branch ↗︎

Tests for review

Failed  study-list/OHIFStudyList.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF Study List > Desktop resolution > Displays several studies initially Test Replay Screenshots Video
Failed  measurement-tracking/OHIFCornerstoneToolbar.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF Cornerstone Toolbar > checks if all primary buttons are being displayed Test Replay Screenshots Video
Failed  volume/MPR.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF MPR > should not go MPR for non reconstructible displaySets Test Replay Screenshots Video
Failed  measurement-tracking/OHIFMeasurementPanel.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF Measurement Panel > checks if Measurements right panel can be hidden/displayed Test Replay Screenshots Video
Failed  customization/HangingProtocol.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF HP > Should display 3 up Test Replay Screenshots Video

The first 5 failed specs are shown, see all 14 specs in Cypress Cloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sedghi