Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(createReport): early return on cancel in prompt #4243

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Billuc
Copy link

@Billuc Billuc commented Jun 20, 2024

Context

The createReportDialogPrompt is used to store/export DICOM SEGs. Currently, data is stored whether one click on 'Save' or 'Cancel'. The desired behaviour is that nothing happens if the "Cancel" button is clicked;

Changes & Results

  • Fixed a condition for an early return in storeSegmentation (the function that creates the report)
  • Added an early return in createReportAsync if no report has been created

Testing

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: Fedora 40
  • Node version: 18.20.3
  • Browser: Chromium Version 126.0.6478.55 (Official Build) Fedora Project (64-bit)

Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for ohif-platform-docs canceled.

Name Link
🔨 Latest commit b892cea
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/667437c4c782200008b0151c

Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for ohif-dev canceled.

Name Link
🔨 Latest commit b892cea
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/667437c472561700086a469a

@sedghi sedghi requested a review from IbrahimCSAE June 21, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant