Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(measurement service): Implemented correct check of schema keys in _isValidMeasurment. #3750

Merged
merged 1 commit into from
Oct 30, 2023
Merged

fix(measurement service): Implemented correct check of schema keys in _isValidMeasurment. #3750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions platform/core/src/services/MeasurementService/MeasurementService.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,25 @@ describe('MeasurementService.js', () => {
}).toThrow();
});

it('throws Error if adding measurement with unknown schema key', () => {
measurementService.addMapping(
source,
annotationType,
matchingCriteria,
toSourceSchema,
() => {
return {
...measurement,
invalidSchemaKey: 0,
};
}
);

expect(() => {
source.annotationToMeasurement(annotationType, measurement);
}).toThrow();
});

it('updates existing measurement', () => {
measurementService.addMapping(
source,
Expand Down
6 changes: 3 additions & 3 deletions platform/core/src/services/MeasurementService/MeasurementService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,14 +691,14 @@ class MeasurementService extends PubSubService {
* @return {boolean} Measurement validation
*/
_isValidMeasurement(measurementData) {
Object.keys(measurementData).forEach(key => {
return Object.keys(measurementData).every(key => {
if (!MEASUREMENT_SCHEMA_KEYS.includes(key)) {
log.warn(`Invalid measurement key: ${key}`);
return false;
}
});

return true;
return true;
});
}

/**
Expand Down