Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat hp search recover from incomplete or missing series/stages #3538

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ladeirarodolfo
Copy link
Collaborator

Context

Hanging protocol approach must consider rollback search in case no display set match or stages for matched protocol.
If that occurs it will try the next best match.

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

@netlify
Copy link

netlify bot commented Jul 14, 2023

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit ccc129a
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/64b1873eeac2b50007ec9974
😎 Deploy Preview https://deploy-preview-3538--ohif-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 14, 2023

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit ccc129a
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/64b1873e46b19500079461e5
😎 Deploy Preview https://deploy-preview-3538--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #3538 (ccc129a) into master (18156bb) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3538      +/-   ##
==========================================
+ Coverage   42.75%   42.87%   +0.11%     
==========================================
  Files          82       82              
  Lines        1450     1453       +3     
  Branches      338      338              
==========================================
+ Hits          620      623       +3     
  Misses        667      667              
  Partials      163      163              
Impacted Files Coverage Δ
.../services/HangingProtocolService/ProtocolEngine.js 86.53% <100.00%> (+0.82%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 265c1fb...ccc129a. Read the comment docs.

@cypress
Copy link

cypress bot commented Jul 14, 2023

1 failed tests on run #3370 ↗︎

1 35 0 0 Flakiness 0

Details:

feat hp search recover from incomplete or missing series/stages
Project: Viewers Commit: ccc129a6f0
Status: Failed Duration: 03:39 💡
Started: Jul 14, 2023 5:39 PM Ended: Jul 14, 2023 5:42 PM
Failed  cypress/integration/customization/HangingProtocol.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF HP > Should navigate next/previous stage Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

studies: this.studies,
activeStudy,
displaySets,
});
this._setProtocol(matchedProtocol);
let nthBestMatch = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should just throw the exception if a specific protocol is specified

}
} else {
stage.status = 'disabled';
} catch (e) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should avoid touching this code here.

}
}

// it means there is no valid stage
if (failureCounter === stages.length) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you can just iterate over the stages and see if there is a passive or enabled one, rather than throwing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants