Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saving of SR with calibration #3503

Closed
wants to merge 1 commit into from
Closed

Conversation

wayfarer3130
Copy link
Contributor

Context

Update to go along with changes to how the calibration gets applied - just use a scale value instead of messing around with units.

Changes & Results

Call the new scale API.
Needs the updated CS3D libraries.

Testing

Use the calibraiton line tool, it should work as expected (no functional change)
Save a DICOM SR after calibrating. The SR viewport should show exactly what was saved, but the calibration will not be restored after loading.

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

@netlify
Copy link

netlify bot commented Jun 28, 2023

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 48009de
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/649ca6646ddf5900080b733e
😎 Deploy Preview https://deploy-preview-3503--ohif-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jun 28, 2023

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 48009de
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/649ca6648f0234000848dc17
😎 Deploy Preview https://deploy-preview-3503--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wayfarer3130 wayfarer3130 requested a review from jbocce June 28, 2023 21:30
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #3503 (48009de) into master (ef4f286) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3503   +/-   ##
=======================================
  Coverage   38.27%   38.27%           
=======================================
  Files          82       82           
  Lines        1348     1348           
  Branches      303      303           
=======================================
  Hits          516      516           
  Misses        666      666           
  Partials      166      166           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a8ae23...48009de. Read the comment docs.

@cypress
Copy link

cypress bot commented Jun 28, 2023

Passing run #3325 ↗︎

0 36 0 0 Flakiness 0

Details:

Fix saving of SR with calibration
Project: Viewers Commit: 48009ded06
Status: Passed Duration: 03:26 💡
Started: Jun 28, 2023 9:34 PM Ended: Jun 28, 2023 9:38 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant