fix(measurement service): Implemented correct check of schema keys in…

… _isValidMeasurment. (#3750)
OHIF · Oct 30, 2023 · db39585 · db39585
1 parent 423ba7c
commit db39585
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 3 deletions.
diff --git a/platform/core/src/services/MeasurementService/MeasurementService.test.js b/platform/core/src/services/MeasurementService/MeasurementService.test.js
@@ -324,6 +324,25 @@ describe('MeasurementService.js', () => {
       }).toThrow();
     });
 
+    it('throws Error if adding measurement with unknown schema key', () => {
+      measurementService.addMapping(
+        source,
+        annotationType,
+        matchingCriteria,
+        toSourceSchema,
+        () => {
+          return {
+            ...measurement,
+            invalidSchemaKey: 0,
+          };
+        }
+      );
+
+      expect(() => {
+        source.annotationToMeasurement(annotationType, measurement);
+      }).toThrow();
+    });
+
     it('updates existing measurement', () => {
       measurementService.addMapping(
         source,

diff --git a/platform/core/src/services/MeasurementService/MeasurementService.ts b/platform/core/src/services/MeasurementService/MeasurementService.ts
@@ -691,14 +691,14 @@ class MeasurementService extends PubSubService {
    * @return {boolean} Measurement validation
    */
   _isValidMeasurement(measurementData) {
-    Object.keys(measurementData).forEach(key => {
+    return Object.keys(measurementData).every(key => {
       if (!MEASUREMENT_SCHEMA_KEYS.includes(key)) {
         log.warn(`Invalid measurement key: ${key}`);
         return false;
       }
-    });
 
-    return true;
+      return true;
+    });
   }
 
   /**