segment-region: clip polygons to parent... #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
==========================================
- Coverage 36.28% 36.13% -0.15%
==========================================
Files 9 9
Lines 995 1010 +15
Branches 219 224 +5
==========================================
+ Hits 361 365 +4
- Misses 567 575 +8
- Partials 67 70 +3
Continue to review full report at Codecov.
|
kba
approved these changes
May 22, 2020
| def polygon_for_parent(polygon, parent): | ||
| """Clip polygon to parent polygon range. | ||
|
|
||
| (Should be moved to ocrd_utils.coordinates_for_segment.) |
bertsky
force-pushed
the
fix-polygon-for-parent
branch
from
47dd21b
to
9e5f8e0
Compare
(before annotating polygon coordinates, ensure they fit into their parent if it exists, or the page frame otherwise)
bertsky
force-pushed
the
fix-polygon-for-parent
branch
from
9e5f8e0
to
94719f8
Compare
|
@kba could you please merge this as well and make another release? (We can take it out again as soon as this is handled by core, but given the many recent and coming changes to the PAGE API, the rewrite will probably be rather large and take more time.) |
|
Sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(before annotating polygon coordinates, ensure they fit
into their parent if it exists, or the page frame otherwise)
This happens for example when the page was deskewed and the region is already on the edge of the (rotated, enlarged) page frame. So the result would be syntactically invalid.
This is another (previously undetected) instance of OCR-D/core#489, with the same solution.