New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI decorator: only import ocrd_network when needed #1289

Merged

kba merged 1 commit into master from cli-decorator-import-network

Oct 10, 2024

Collaborator

bertsky commented Oct 10, 2024

Avoids about 17 MB RSS of unnecessary networking imports when not using the networking subcommands on the CLI.


          CLI decorator: only import ocrd_network when needed

cb8d787

bertsky requested a review from MehmedGIT

October 10, 2024 11:11

kba approved these changes

View reviewed changes

Member

kba left a comment

import below module top-level is normally frowned upon but in this case it makes sense, no need to pull all of that in if it is not used. LGTM

MehmedGIT approved these changes

View reviewed changes

kba merged commit 539f5d7 into master

22 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet