#1240 backports for v2 #1275
Merged
#1240 backports for v2 #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Konstantin Baierer <[email protected]>
…up (also, simplify)
kba
approved these changes
Sep 30, 2024
| run_processor(processorClass, mets_url=mets, workspace=workspace, **kwargs) | ||
| atexit.register(goexit) | ||
| if log_filename: | ||
| log_ctx = redirect_stderr_and_stdout_to_file(log_filename) |
There was a problem hiding this comment.
BTW this is one of the things I got rid of in the fork for our k8s deployment.
There was a problem hiding this comment.
Is it bad then? Should we remove it from the CLI?
There was a problem hiding this comment.
No, but something we should discuss because that does not play well with k8s.
Co-authored-by: Konstantin Baierer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed this is basically a cherry-picked version of #1240 with just the fixes (and some minor additions to get tests running smoothly again).
Changelog must also be cherry-picked from, but that's completely manual and can be done after review.
Most importantly, this solves the problems with Pillow 10.