[17.0] [MIG] sale_packaging_default: Migration to 17.0 #3334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module simplifies and emphasizes the usage of packaging in sales orders. - Packaging fields in sale order lines appear before product quantity fields. - When selecting a product to sell, its default packaging is added automatically. Why is this module useful? Packaging usage in Odoo is designed to be computed automatically when you choose the final amount of products to sell. Although you can still do that, with this module the natural usage is inverted: it's easier for you to select the packaging and quantity first, and then the final amount of products is computed automatically. @moduon MT-3695
Currently translated at 100.0% (4 of 4 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_packaging_default Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_packaging_default/es/
When creating SO from mobile view or from "Commercial Quotations" menu installed by `sale_order_product_picker`, the pop-up form view that appears when clicking on the line kanban kard didn't have the fields in the correct order. @moduon MT-3930
…ckaging Before this patch, we had this problem: 1. Add new SO line. 2. Set a packaging and a packaging qty. The UoM qty is computed. Good. 3. Set UoM qty to zero. Packaging and packaging qty remain with previous value. Bad. When user sets UoM to zero, Odoo should remove any packaging information. Notice that, when adding a new line, that qty will be zero at the beginning, but we will want to still get the defaults. Thus, this change is only applied when the user *is* actually setting that value, and not on any other circumstance. I needed to override the `onchange()` method to propagate that information. @moduon MT-3930
…ker` Make sure that, when adding a new line that inherits the product by a `default_product_id` context, there is no warning about wrong amount of products. @moduon MT-4369
Currently translated at 100.0% (4 of 4 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_packaging_default Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_packaging_default/it/
It turns out that, since product packagings can be sorted, and can already be set as `sales=True`, we can safely consider that the 1st packaging with that field on is the default one for sales. We loose the ability to set one product with sales packagings to not have a default one, but we win in the sense that we don't diverge from Odoo CE DB model. That advantage means that the "packaging_default" family of modules are now just a plug-in that will emphasize the usage of packagings in the sale process, but other modules that use the same data model can reason similarly without depending directly on these ones. @moduon MT-4396
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_packaging_default Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_packaging_default/
Add _get_default_packaging. Allows replicating the same logic when needed.
Currently translated at 100.0% (2 of 2 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_packaging_default Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_packaging_default/es/
When changing the line product, before this patch we had upstream Odoo behavior unchanged: keep the uom qty and recompute the packaging qty accordingly. This gave a poor UX because, when using this addon, you expect packaging qty to have priority over uom qty. Thus, if you changed from selling 2 packagings of one product packaged by default in 6-packs (thus 12 units) to another product with a default sales packaging of 3-packs, you expect to be still selling 2 packagings (thus 6 units). @moduon MT-5444
bizzappdev
force-pushed
the
17.0-mig-sale_packaging_default-BAD-RUS
branch
from
af59c18
to
4a0292a
Compare
|
/ocabot migration sale_packaging_default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.