[14.0][FIX] sale_order_line_input: access to action views #3314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toita86
force-pushed
the
14.0-FIX-sale_order_line_input-toita86
branch
from
bfec49c
to
ad34b52
Compare
rousseldenis
changed the title
rousseldenis
requested changes
Sep 17, 2024
| @@ -0,0 +1,5 @@ | |||
| id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink | |||
| access_window_action_form_user,access_window_action_form_user,base.model_ir_actions_act_window,sale_order_line_input.group_sale_order_access,1,0,0,0 | |||
There was a problem hiding this comment.
@toita86 You cannot do that as it will give you access to the whole model.
The problem is here: https://github.com/OCA/sale-workflow/blob/14.0/sale_order_line_input/models/sale_order.py#L57
You should change the code to retrieve the action through for_xml_idfunction. Look into core code.
There was a problem hiding this comment.
Thank you for the explanation!
I have changed my approach based on your suggestion, now should be correct.
toita86
force-pushed
the
14.0-FIX-sale_order_line_input-toita86
branch
3 times, most recently
from
eca05ee
to
c5ab95f
Compare
toita86
force-pushed
the
14.0-FIX-sale_order_line_input-toita86
branch
from
c5ab95f
to
de3853d
Compare
francesco-ooops
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously of this fix when a user with access to all the SO tries to access one of them through the "Open Order" widget there will produce an error:
