Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][IMP] sale_quotation_number: allow customizable quotation sequence #3310

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

MohamedOsman7
Copy link

@MohamedOsman7 MohamedOsman7 commented Sep 12, 2024

Enable users to customize the sale.quotation sequence prefix, instead of it being restricted to the default 'SQ'.

Solution from version 14: #2126

(PR 16: #3309 )
(PR 15: #3311 )

(Follow-up PR: #3213)

Copy link
Contributor

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code + tested

@rousseldenis
Copy link
Sponsor Contributor

@MohamedOsman7 Ok, next time, the better is to cheery-pick the original fix and then do the modification (the search before the loop) to keep original author. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants