Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] sql_request_abstract: Migration to 18.0 #937

Open
wants to merge 91 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] sql_request_abstract: Migration to 18.0 #937

wants to merge 91 commits into from

Conversation

thienvh332
Copy link

legalsylvain and others added 30 commits October 10, 2024 10:46
@legalsylvain @thienvh332
create a new module sql_request_abstract
9a1ba6b
@florian-dacosta @thienvh332
Fix version
d3bec88
@legalsylvain @thienvh332
various improvement. Courtesy @dreispt review
0e9e178
@oca-transbot @thienvh332
OCA Transbot updated translations from Transifex
ca64d65
@oca-transbot @thienvh332
OCA Transbot updated translations from Transifex
c3daad4
@serpentcs-dev1 @thienvh332
[MIG] sql_request_abstract v10
c4eb42d
@oca-transbot @thienvh332
OCA Transbot updated translations from Transifex
7cacfa6
@sbidoul @thienvh332
remove obsolete .pot files [ci skip]
0c8dd76
@oca-travis @thienvh332
[UPD] Update sql_request_abstract.pot
3b45583
@MiquelRForgeFlow @thienvh332
[FIX] mogrify doesn't allow dicts
d56f8fa
@oca-travis @thienvh332
[UPD] Update sql_request_abstract.pot
4972f45
@HviorForgeFlow @thienvh332
[MIG] sql_request_abstract: Migration to 11.0
57a49b3
@oca-travis @thienvh332
[UPD] Update sql_request_abstract.pot
56e0e14
@oca-transbot @thienvh332
Update translation files
19240ae 
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@AdriaGForgeFlow @thienvh332
[12.0][MIG] Migrate module sql_request_abstract to v12
695dfb8
@OCA-git-bot @thienvh332
[UPD] README.rst
661ad2a
@oca-travis @thienvh332
[UPD] Update sql_request_abstract.pot
b22b52d
@oca-transbot @thienvh332
Update translation files
2de23da 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-12.0/server-tools-12.0-sql_request_abstract
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-sql_request_abstract/
@bealdav @thienvh332
FIX sql_request_abstract: b64encode use a Bytes like object
b699121
@oca-travis @thienvh332
[UPD] Update sql_request_abstract.pot
b38108d
@oca-transbot @thienvh332
Update translation files
4454f47 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-12.0/server-tools-12.0-sql_request_abstract
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-sql_request_abstract/
@OCA-git-bot @thienvh332
[UPD] README.rst
adc3270
@liweijie0812 @thienvh332
Translated using Weblate (Chinese (Simplified))
346d3d1 
Currently translated at 100.0% (21 of 21 strings)

Translation: server-tools-12.0/server-tools-12.0-sql_request_abstract
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-sql_request_abstract/zh_CN/
@thienvh332
Translated using Weblate (Portuguese (Brazil))
3780499 
Currently translated at 100.0% (21 of 21 strings)

Translation: server-tools-12.0/server-tools-12.0-sql_request_abstract
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-sql_request_abstract/pt_BR/
@bealdav @thienvh332
ADD module mrp_component_consumption_gap
9a58687
@oca-travis @thienvh332
[UPD] Update sql_request_abstract.pot
ca8f6ce
@oca-transbot @thienvh332
Update translation files
ebed7da 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-12.0/server-tools-12.0-sql_request_abstract
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-sql_request_abstract/
@thienvh332
[IMP] sql_request_abstract black, isort
68f9446
@thienvh332
[MIG] sql_request_abstract: Migration to 13.0
598d4ce
@oca-travis @thienvh332
[UPD] Update sql_request_abstract.pot
371a028
oca-ci and others added 22 commits October 10, 2024 10:46
@thienvh332
[UPD] Update sql_request_abstract.pot
c61b1fd
@weblate @thienvh332
Update translation files
33a1c8a 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: reporting-engine-16.0/reporting-engine-16.0-sql_request_abstract
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-sql_request_abstract/
@mymage @thienvh332
Translated using Weblate (Italian)
65c6750 
Currently translated at 14.2% (6 of 42 strings)

Translation: reporting-engine-16.0/reporting-engine-16.0-sql_request_abstract
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-sql_request_abstract/it/
@nguyenminhchien @thienvh332
[IMP] sql_request_abstract: pre-commit auto fixes
ed72102
@nguyenminhchien @thienvh332
[MIG] sql_request_abstract: Migration to 17.0
5a2a2e1
@thienvh332
[UPD] Update sql_request_abstract.pot
4cf283f
@OCA-git-bot @thienvh332
[BOT] post-merge updates
e263d3e
@weblate @thienvh332
Update translation files
934136d 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: reporting-engine-17.0/reporting-engine-17.0-sql_request_abstract
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-17-0/reporting-engine-17-0-sql_request_abstract/
@weblate @thienvh332
Update translation files
d4713b1 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: reporting-engine-17.0/reporting-engine-17.0-sql_request_abstract
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-17-0/reporting-engine-17-0-sql_request_abstract/
@Ivorra78 @thienvh332
Translated using Weblate (Spanish)
7f21c63 
Currently translated at 95.4% (42 of 44 strings)

Translation: reporting-engine-17.0/reporting-engine-17.0-sql_request_abstract
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-17-0/reporting-engine-17-0-sql_request_abstract/es/
@Ivorra78 @thienvh332
Translated using Weblate (Spanish)
d958425 
Currently translated at 100.0% (44 of 44 strings)

Translation: reporting-engine-17.0/reporting-engine-17.0-sql_request_abstract
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-17-0/reporting-engine-17-0-sql_request_abstract/es/
@mymage @thienvh332
Translated using Weblate (Italian)
f80f0ba 
Currently translated at 100.0% (44 of 44 strings)

Translation: reporting-engine-17.0/reporting-engine-17.0-sql_request_abstract
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-17-0/reporting-engine-17-0-sql_request_abstract/it/
@jakobkrabbe @thienvh332
Translated using Weblate (Swedish)
58e6276 
Currently translated at 100.0% (44 of 44 strings)

Translation: reporting-engine-17.0/reporting-engine-17.0-sql_request_abstract
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-17-0/reporting-engine-17-0-sql_request_abstract/sv/
@thienvh332
[UPD] Update sql_request_abstract.pot
0f3a817
@weblate @thienvh332
Update translation files
6e5913a 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: reporting-engine-17.0/reporting-engine-17.0-sql_request_abstract
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-17-0/reporting-engine-17-0-sql_request_abstract/
@thienvh332
[UPD] Update sql_request_abstract.pot
7b9d925
@weblate @thienvh332
Update translation files
95603fc 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: reporting-engine-17.0/reporting-engine-17.0-sql_request_abstract
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-17-0/reporting-engine-17-0-sql_request_abstract/
@ibuioli @thienvh332
Translated using Weblate (Spanish (Argentina))
08e4f37 
Currently translated at 100.0% (43 of 43 strings)

Translation: reporting-engine-17.0/reporting-engine-17.0-sql_request_abstract
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-17-0/reporting-engine-17-0-sql_request_abstract/es_AR/
@florian-dacosta @thienvh332
[IMP] Make possible to make sql queries on an external database
51fadc2
@thomaspaulb @thienvh332
[FIX] sql_request_abstract: regression
55b2eed
@thienvh332
[IMP] sql_request_abstract: apply pre-commit auto fixes
0cd6828
@thienvh332
[MIG] sql_request_abstract: Migration to 18.0
ed04bed
@thienvh332 thienvh332 marked this pull request as draft October 10, 2024 04:05
@thienvh332 thienvh332 marked this pull request as ready for review October 10, 2024 04:10
@thienvh332 thienvh332 mentioned this pull request Oct 10, 2024
Open
@legalsylvain
Copy link
Contributor

hi. could you take a look on red CI ? thanks !

@thienvh332
Copy link
Author

Hi @legalsylvain ,
I updated it. Could you have a look?

legalsylvain
legalsylvain reviewed Oct 11, 2024
View reviewed changes
checklog-odoo.cfg
@@ -0,0 +1,3 @@
[checklog-odoo]
ignore=
WARNING.*0 failed, 0 error\(s\).*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this addition ?

Copy link
Author

@thienvh332 thienvh332 Oct 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module originally had no test case and the new oca-ci test case was raising errors even with WARNING. So I added it to avoid being labeled as ERROR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hum. something is wrong if CI is red if there are no test, it is a valid use case. I think that something should be fixed in checklog-odoo tools instead.

@sbidoul : what do you think ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something should be fixed in checklog-odoo tools instead.

We don't want to special case this in checklog-odoo, because we have had situations where for some reason tests did not run had that error was actually helpful.

This problem will only occur when the first module migrated has no test, so in practice this should not occur often, I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbidoul sbidoul sbidoul left review comments

@legalsylvain legalsylvain legalsylvain left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.