[16.0][MIG] kpi: Migration to 16.0 #920
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* kpi migration to odoo 9 * UI error connected * Correction base on last maxime review * correction on @elicoidal review * Warning exception improve in kpi_threshold * Latest Ellicoidal comment implemented * last Ellicoial recommendation done. * Copyright corrected
Currently translated at 100.0% (68 of 68 strings) Translation: reporting-engine-12.0/reporting-engine-12.0-kpi Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-kpi/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-12.0/reporting-engine-12.0-kpi Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-kpi/
Currently translated at 100.0% (79 of 79 strings) Translation: reporting-engine-12.0/reporting-engine-12.0-kpi Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-kpi/pt_BR/
jok-adhoc
reviewed
Aug 21, 2024
kpi/models/kpi.py
Outdated
| kpi_type = fields.Selection( | ||
| [ | ||
| ("python", "Python"), | ||
| ("local", "SQL - Local DB"), |
There was a problem hiding this comment.
according L122 this must be 'local' --> 'sql'
jok-adhoc
reviewed
Aug 21, 2024
kpi/models/kpi.py
Outdated
| [ | ||
| ("python", "Python"), | ||
| ("local", "SQL - Local DB"), | ||
| ("external", "SQL - External DB"), |
jok-adhoc
reviewed
Aug 21, 2024
kpi/models/kpi.py
Outdated
|
|
||
| next_execution_date = fields.Datetime(readonly=True) | ||
| value = fields.Float(compute="_compute_display_last_kpi_value") | ||
| color = fields.Text(compute="_compute_display_last_kpi_value") |
There was a problem hiding this comment.
because we're removing threshold to simplify the module, color should not exist
matiasperalta1
force-pushed
the
16.0-t-30706-mnp
branch
from
b5bfd94
to
a087f91
Compare
jok-adhoc
reviewed
Sep 9, 2024
| <field name="next_execution_date" colspan="3" /> | ||
| <separator string="KPI Computation" colspan="6" /> | ||
| <newline /> | ||
| <field name="kpi_type" colspan="2" /> |
There was a problem hiding this comment.
It would be better to have colspan equal to "6" in order to have both kpi_type and kpi_code one bellow the other. Another option could be creating two diff groups
With colspan = "2" , the code's label is in the same line as kpi_type and the editable field bellow, what makes the label confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.