Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD][16.0] product_english_name module #1732

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

bealdav
Copy link
Member

@bealdav bealdav commented Sep 30, 2024

Copy link

@PaulGoubert PaulGoubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionnal review OK

Copy link
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this attribution.
Some minor comments about warning and language.

Adittionally non blocking comment.
Compatability with product profile could be improved. As seen on runboat:
image

@@ -0,0 +1,4 @@
- active another language than english and set it to your user.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- active another language than english and set it to your user.
- activate another language than English and set it as your user language.

@@ -0,0 +1,4 @@
- active another language than english and set it to your user.
- add your user to 'Show english name' group.
- browse your products in form view.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- browse your products in form view.
- browse your products in a form view.

This module display product name in english near name in user language.

Use case:
Product name is a very important information at least you buy products in a foreign country.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Product name is a very important information at least you buy products in a foreign country.
The Product name is very important information at least if you buy products in a foreign country.

Use case:
Product name is a very important information at least you buy products in a foreign country.
It often occurs that in an odoo instance product names don't match with their translations.
This module can help to detect error on translations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This module can help to detect error on translations.
This module can help to detect those translation errors.

<field name="inherit_id" ref="product.product_template_form_view" />
<field name="arch" type="xml">
<xpath expr="//h1[1]" position="after">
<h5 groups="product_english_name.show_english_name">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


2024-09-30 14:58:43,884 478 WARNING odoo odoo.addons.base.models.ir_ui_view: The group 'product_english_name.show_english_name' defined in view does not exist!
View error context:
{'file': '/__w/product-attribute/product-attribute/product_english_name/views/product_template.xml',
 'line': 3,
 'name': 'product.template form',
 'view': ir.ui.view(1841,),
 'view.model': 'product.template',
 'view.parent': ir.ui.view(464,),
 'xmlid': 'product_template_form_view'} 

This module can help to detect error on translations.

.. figure:: ../static/description/screen_french.png
:alt: Display product name in english near name in user language
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:alt: Display product name in english near name in user language
:alt: Display the product name in English near the product name in users language

<odoo>

<record id="show_english_name" model="res.groups">
<field name="name">Show english name</field>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="name">Show english name</field>
<field name="name">Show English name</field>

# Copyright 2024 Akretion
{
"name": "Product English Name",
"summary": """Display product name in english """,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"summary": """Display product name in english """,
"summary": """Display the product name in English besides the product name in the users language. """,

@@ -0,0 +1,12 @@
This module display product name in english near name in user language.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This module display product name in english near name in user language.
This module displays the product name in English near the products name in user's language.


Use case:
Product name is a very important information at least you buy products in a foreign country.
It often occurs that in an odoo instance product names don't match with their translations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It often occurs that in an odoo instance product names don't match with their translations.
It often occurs that in an odoo instance the product names don't match with their translations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants