Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] commit tags rendering #183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

SirAionTech
Copy link

No description provided.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that should be a specific tag. Starting with, a code coverage only improvement is very weird. This improvement is usually done when touching other things. But the key is that this is an improvement, so it should be [IMP] IMO. We don't need a specialized tag for that. The more tags we have, the more confusing the system is.

@SirAionTech
Copy link
Author

I don't think that should be a specific tag. Starting with, a code coverage only improvement is very weird. This improvement is usually done when touching other things. But the key is that this is an improvement, so it should be [IMP] IMO. We don't need a specialized tag for that. The more tags we have, the more confusing the system is.

I thought improvements only happened when the functionality of a module changes, since adding just a test does not improve the functionality then I thought to a separate tag.
If [IMP] commits can contain only tests that's ok too by me.

I'll just fix the rendering then.

@SirAionTech SirAionTech changed the title Add [COV] commit tag [FIX] commit tags rendering Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants