Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] base_geoengine_demo: Migration to 17.0 #372

Open
wants to merge 93 commits into
base: 17.0
Choose a base branch
from

Conversation

peluko00
Copy link

@peluko00 peluko00 commented May 21, 2024

@peluko00 peluko00 force-pushed the 17.0-mig-base_geoengine_demo branch 2 times, most recently from 0f95f19 to 7ae2c6a Compare May 21, 2024 11:51
Copy link

@miquelalzanillas miquelalzanillas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested functionally. LGTM.

@miquelalzanillas
Copy link

miquelalzanillas commented May 22, 2024

Tested functionally. LGTM.

Sorry but I didn't tested following the 'base_geoengine_demo' readme and trying to follow those indications still are some bugs.

@peluko00 peluko00 force-pushed the 17.0-mig-base_geoengine_demo branch from 7ae2c6a to 6d5eaa4 Compare June 13, 2024 07:18
@peluko00 peluko00 force-pushed the 17.0-mig-base_geoengine_demo branch 2 times, most recently from 547efc5 to 2c895f1 Compare September 27, 2024 12:25
@peluko00
Copy link
Author

It's ready to be merge @dreispt

@dreispt
Copy link
Sponsor Member

dreispt commented Sep 27, 2024

@peluko00 Can you please rebase on latest 17.0, and ensure that that last Merge commit is not in the history?

@peluko00 peluko00 force-pushed the 17.0-mig-base_geoengine_demo branch 2 times, most recently from 1712894 to 3223b4c Compare September 30, 2024 06:31
@peluko00
Copy link
Author

@peluko00 Can you please rebase on latest 17.0, and ensure that that last Merge commit is not in the history?

Done, thanks! Now it's ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.