Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][mig] web_view_leaflet_map and web_view_leaflet_map_partner #342

Merged
merged 9 commits into from
Dec 11, 2023
Merged

[16.0][mig] web_view_leaflet_map and web_view_leaflet_map_partner #342

merged 9 commits into from
Dec 11, 2023

Conversation

legalsylvain
Copy link
Contributor

@legalsylvain legalsylvain commented Jun 29, 2023 •
edited
Loading

  • Trivial port of the modules : web_view_leaflet_map and web_view_leaflet_map_partner

  • mig commit to review : 1e873b6

  • bump leaflet lib from 1.8.0 , released on April 18, 2022 to 1.9.4, released on May 18, 2023.

res_partner_map

@legalsylvain
Copy link
Contributor Author

legalsylvain commented Jun 29, 2023 •
edited
Loading

/ocabot migration web_view_leaflet_map_partner

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 29, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 29, 2023
Open
6 tasks
@legalsylvain
Copy link
Contributor Author

/ocabot migration web_view_leaflet_map

@legalsylvain legalsylvain force-pushed the 16.0-mig-web_view_leaflet_map branch from a4d3203 to 3907dbe Compare June 29, 2023 16:12
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 29, 2023
@legalsylvain legalsylvain marked this pull request as ready for review October 29, 2023 17:05
@PaulGoubert
Copy link

Hello @legalsylvain and thank you for this PR.
FYI, doing a functionnal review, and this working fine til trying to "group by" where I've an error "Uncaught Promise > Cannot read properties of undefined (reading 'lat')"

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 5, 2023
@legalsylvain legalsylvain mentioned this pull request Nov 30, 2023
Closed
@legalsylvain
Copy link
Contributor Author

hi @PaulGoubert . Nice catch !
I disabled the button "group by" (that makes no sense in a map context).

Could you test again, and update your review ?

thanks !

@PaulGoubert
Copy link

LGTM. Thank you @legalsylvain

PaulGoubert
PaulGoubert approved these changes Nov 30, 2023
View reviewed changes
Copy link

@PaulGoubert PaulGoubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Review OK.

navarrorico
navarrorico reviewed Dec 11, 2023
View reviewed changes
Copy link

@navarrorico navarrorico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@legalsylvain
Copy link
Contributor Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Sorry @legalsylvain you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@legalsylvain
Copy link
Contributor Author

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Sorry @legalsylvain you are not allowed to rebase.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@legalsylvain
Copy link
Contributor Author

geospacial maintainers : could you merge this one ? Thanks !
@yvaucher, @lmignon

@pedrobaeza
Copy link
Member

Merging due to existing reviews:

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-342-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 10c82d3 into OCA:16.0 Dec 11, 2023
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 22435d1. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarrorico navarrorico navarrorico approved these changes

@PaulGoubert PaulGoubert PaulGoubert approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@legalsylvain @PaulGoubert @OCA-git-bot @pedrobaeza @navarrorico