Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] calendar_event_type_color #112

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[ADD] calendar_event_type_color #112

wants to merge 1 commit into from

Conversation

yankinmax
Copy link

This module allows to set color on event type in tree view.
It gives possibility to colorize calendar view by event type colors.
Color is computed from first event type of calendar event categ_ids field.

@yankinmax yankinmax mentioned this pull request Dec 1, 2023
Closed
ivantodorovich
ivantodorovich reviewed Jan 18, 2024
View reviewed changes
calendar_event_type_color/views/calendar_event_type_views.xml
id="calendar_management_menu"
name="Calendar Event Type"
parent="calendar.mail_menu_calendar"
action="calendar_event_type_action"

This comment was marked as resolved.

Sign in to view

@yankinmax yankinmax force-pushed the add-calendar_event_type_color branch from d36edcc to 5dec930 Compare January 23, 2024 07:42
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 2, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 2, 2024
@cvinh
Copy link

cvinh commented Jun 2, 2024

@OCA/web-maintainers can you please merge ?

@etobella
Copy link
Member

etobella commented Jun 2, 2024

/ocabot merge rebase

@OCA-git-bot
Copy link
Contributor

Hi @etobella. Your command failed:

Invalid options for command merge: rebase.

Ocabot commands

  • ocabot merge major|minor|patch|nobump
  • ocabot rebase
  • ocabot migration {MODULE_NAME}

More information

@etobella
Copy link
Member

etobella commented Jun 2, 2024

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 16.0.

@OCA-git-bot OCA-git-bot force-pushed the add-calendar_event_type_color branch from 5dec930 to 5b80a09 Compare June 2, 2024 18:56
etobella
etobella reviewed Jun 2, 2024
View reviewed changes
calendar_event_type_color/models/calendar_event.py Show resolved Hide resolved
calendar_event_type_color/readme/DESCRIPTION.rst Outdated
@@ -0,0 +1,3 @@
This module allows to set color on event type in tree view.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The field is not stored, so it cannot be set, it just takes the color of the first category (not the first inserted, the first according to the order of the categories).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the field is already there in core, but this module does expose it on the tree view

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 9, 2024
ivantodorovich
ivantodorovich suggested changes Aug 15, 2024
View reviewed changes
calendar_event_type_color/views/calendar_event_type_views.xml Outdated Show resolved Hide resolved
calendar_event_type_color/readme/DESCRIPTION.rst Outdated
@@ -0,0 +1,3 @@
This module allows to set color on event type in tree view.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the field is already there in core, but this module does expose it on the tree view

@yankinmax yankinmax force-pushed the add-calendar_event_type_color branch from 5b80a09 to 5489a96 Compare August 15, 2024 15:54
@yankinmax yankinmax force-pushed the add-calendar_event_type_color branch from 5489a96 to 1990336 Compare August 15, 2024 15:56
ivantodorovich
ivantodorovich approved these changes Aug 15, 2024
View reviewed changes
Copy link

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etobella etobella etobella left review comments

@ivantodorovich ivantodorovich ivantodorovich approved these changes

@Camille0907 Camille0907 Camille0907 approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yankinmax @OCA-git-bot @cvinh @etobella @ivantodorovich @Camille0907