return counts from RestoreTask for PackageReference projects #6049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
previously approved these changes
Sep 24, 2024
| @@ -51,6 +51,9 @@ internal class AuditUtility | |||
| internal int DistinctAdvisoriesSuppressedCount { get; private set; } | |||
| internal int TotalWarningsSuppressedCount { get; private set; } | |||
|
|
|||
| /// <inheritdoc cref="RestoreSummary.AuditRan"/> | |||
| internal bool AuditRan { get; private set; } | |||
There was a problem hiding this comment.
I would just have CheckPackageVulnerabilitiesAsync() return Task<bool> and then save the value here to be returned. Just my vote
There was a problem hiding this comment.
I agree, it's pretty much done that way anyways in the 3 places we return.
nkolev92
reviewed
Sep 24, 2024
| @@ -51,6 +51,9 @@ internal class AuditUtility | |||
| internal int DistinctAdvisoriesSuppressedCount { get; private set; } | |||
| internal int TotalWarningsSuppressedCount { get; private set; } | |||
|
|
|||
| /// <inheritdoc cref="RestoreSummary.AuditRan"/> | |||
| internal bool AuditRan { get; private set; } | |||
There was a problem hiding this comment.
I agree, it's pretty much done that way anyways in the 3 places we return.
jeffkl
approved these changes
Sep 27, 2024
nkolev92
reviewed
Sep 27, 2024
| @@ -138,7 +138,8 @@ static bool HasProjectToRestore(DependencyGraphSpec dgSpec, bool restorePackages | |||
|
|
|||
| try | |||
| { | |||
| bool result = await BuildTasksUtility.RestoreAsync( | |||
| // todo: need to return Restore task output properties, like in NuGet.targets | |||
There was a problem hiding this comment.
TODO's need to be linked to issues.
Sorry I missed this in the first review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13778
Description
Add properties output properties
RestoreProjectCount,RestoreSkippedCount, andRestoreProjectsAuditedCountto RestoreTask (non-static graph version). Static graph version will be implemented later, and including packages.config projects is waiting for customer feedback.The tests demonstrate how to to fail a restore if NuGetAudit was not enabled for at least 1 project.
PR Checklist