Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add joystick support #13

Merged
merged 8 commits into from
Mar 3, 2024
Merged

feat: add joystick support #13

merged 8 commits into from
Mar 3, 2024

Conversation

winstxnhdw
Copy link
Contributor

@winstxnhdw winstxnhdw commented Feb 18, 2024

Summary

Depends on ROS2's joy package to add universal Linux-only joystick support. Queue size is set to zero because we only always want the latest inputs from the controller. Tested on an Xbox and Nintendo controller.

Usage

ros2 launch sjtu_drone_bringup sjtu_drone_bringup.launch.py controller:="joystick"

Let me know if any changes are required.

Closes #12

Copy link

codeautopilot bot commented Feb 18, 2024

PR summary

The Pull Request adds joystick support to the sjtu_drone package, which previously only supported keyboard input for teleoperation. It introduces a dependency on the ROS2 joy package, which is a Linux-only package for joystick input. The PR includes changes to the launch file to allow users to specify the type of controller (keyboard or joystick) and adds a new executable teleop_joystick for handling joystick inputs. The joystick support is tested with Xbox and Nintendo controllers.

Suggestion

The PR seems well-structured and follows the existing codebase conventions. However, it's important to ensure that the new dependency on the joy package is properly documented, and that installation instructions are provided for users who may not have it installed. Additionally, it might be beneficial to consider cross-platform compatibility for joystick support, as the current implementation is Linux-only.

Disclaimer: This comment was entirely generated using AI. Be aware that the information provided may be incorrect.

Current plan usage: 56.37%

Have feedback or need help?
Discord
Documentation
[email protected]

@NovoG93 NovoG93 merged commit 4a643e2 into NovoG93:ros2 Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Joystick Support
3 participants